Skip to content

Let load! append when source column names differ only in case - #381

Merged
quinnj-bot[bot] merged 2 commits into
masterfrom
claude/load-names-ignore-case
Nov 16, 2026
Merged

quinnj-bot[bot] merged 2 commits into
masterfrom
claude/load-names-ignore-case

Conversation

@quinnj-bot

@quinnj-bot quinnj-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Why

Appending to an existing table with SQLite.load! failed when a source column name differed from the table's only in case. A DataFrame with a NAME column could not be loaded into a table with a name column: Error loading, column names from table ["Id", "NAME"] do not match database names ["name", "id"]. SQLite itself treats column names without regard to case, so the INSERT would have worked. load!'s own duplicate-name check already ignores case.

What changed

  • The name check before appending compares lowercased names. The error message lists the source names in their original order.

Scope

  • Names that differ in more than case still throw, as before.
  • Julia's lowercase folds non-ASCII letters too, while SQLite folds only ASCII. A pair such as É/é now passes this check and fails at the INSERT with SQLite's "no such column" error instead. The duplicate-name check already behaves this way.

Verification

  • New testset load! matches existing column names ignoring case. On master it errors with the message above; on this branch it passes 2/2, including a misspelled name that still throws.
  • Pkg.test() passes on Julia 1.12 and 1.10 (525/525).

🤖 Generated with Claude Code

@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.89%. Comparing base (789098b) to head (05a2698).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
- Coverage   96.90%   96.89%   -0.01%     
==========================================
  Files           5        5              
  Lines         808      806       -2     
==========================================
- Hits          783      781       -2     
  Misses         25       25              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

quinnj and others added 2 commits November 16, 2026 12:55
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SQLite compares column names without regard to case, and checkdupnames
already does. checknames compared them exactly, so load! rejected a
source column NAME for a table column name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@quinnj-bot
quinnj-bot Bot force-pushed the claude/load-names-ignore-case branch from 7d4d059 to 05a2698 Compare November 16, 2026 19:57
@quinnj-bot
quinnj-bot Bot merged commit 0147cdd into master Nov 16, 2026
15 of 16 checks passed
@quinnj-bot
quinnj-bot Bot deleted the claude/load-names-ignore-case branch November 16, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant